-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Maya / Nuke remove publish gui filters from settings #5570
Chore: Maya / Nuke remove publish gui filters from settings #5570
Conversation
@BigRoy I would like to test this PR but Im not so sure for what I should be looking. Could you add more info on that pls? |
I'm not sure either - as far as I can tell these were publisher presets for the old publisher that'd set the Optional states of certain plugins according to the preset. The new publisher doesn't have this concept since it stores and remembers tweaked settings and thus there's much less need for these presets. @iLLiCiTiT @antirotor any idea whether it makes sense to remove these settings? Also note the comment I made about TV Paint in the PR description under Additional Info |
Exactly, this cannot be tested, because settings that were removed, were not used.
Yes, we should remove the settings for them too. I'll leave it up to you if you want to add it to this PR. |
@iLLiCiTiT only for those that do not use the old publisher anymore, correct? (I believe Hiero still does) |
Yes, from the remaining it is only TVPaint. |
…e_publish_gui_filters
Ready to check again @iLLiCiTiT |
# Conflicts: # server_addon/nuke/server/version.py
Changelog Description
Additional info
Note that it seems like both TVPaint and Hiero also have the Publish GUI Filter settings currently - I am not sure if those use the new publisher already and whether it's worth also removing those in this PR or not.
I'm not sure how AYON settings work with its versioning - so let me know if the changes/commits seem like the right way.
Testing notes: